Code modernize (#234)

* refactor: declare exports at runtime and drop the player-data provides alias

Signed-off-by: Mathu-lmn <[email protected]>

* refactor: pass handlers directly to RegisterNetEvent

Signed-off-by: Mathu-lmn <[email protected]>

* refactor: use CreateThread/Wait without the Citizen prefix

Signed-off-by: Mathu-lmn <[email protected]>

* chore: remove trailing whitespace, stray lines and unused locals

Signed-off-by: Mathu-lmn <[email protected]>

---------

Signed-off-by: Mathu-lmn <[email protected]>

resources/[gameplay]/playernames/fxmanifest.lua

@@ -13,19 +13,6 @@ server_script 'playernames_api.lua'
 client_script 'playernames_cl.lua'
 server_script 'playernames_sv.lua'
 
--- make exports
-local exportList = {
-    'setComponentColor',
-    'setComponentAlpha',
-    'setComponentVisibility',
-    'setWantedLevel',
-    'setHealthBarColor',
-    'setNameTemplate'
-}
-
-exports(exportList)
-server_exports(exportList)
-
 -- add files
 files {
     'template/template.lua'

resources/[gameplay]/playernames/playernames_api.lua

@@ -42,6 +42,13 @@ setHealthBarColor = getTriggerFunction('sehc')
 setNameTemplate = getTriggerFunction('tpl')
 setName = getTriggerFunction('name')
 
+exports('setComponentColor', setComponentColor)
+exports('setComponentAlpha', setComponentAlpha)
+exports('setComponentVisibility', setComponentVisibility)
+exports('setWantedLevel', setWantedLevel)
+exports('setHealthBarColor', setHealthBarColor)
+exports('setNameTemplate', setNameTemplate)
+
 if not io then
     io = { write = nil, open = nil }
 end

resources/[gameplay]/playernames/playernames_cl.lua

@@ -142,9 +142,7 @@ local function getSettings(id)
     return mpGamerTagSettings[i]
 end
 
-RegisterNetEvent('playernames:configure')
-
-AddEventHandler('playernames:configure', function(id, key, ...)
+RegisterNetEvent('playernames:configure', function(id, key, ...)
     local args = table.pack(...)
 
     if key == 'tglc' then
@@ -183,7 +181,7 @@ AddEventHandler('onResourceStop', function(name)
     end
 end)
 
-SetTimeout(0, function()
+CreateThread(function()
     TriggerServerEvent('playernames:init')
 end)
 

resources/[gameplay]/playernames/playernames_sv.lua

@@ -7,7 +7,7 @@ local function detectUpdates()
     SetTimeout(500, detectUpdates)
 
     local template = GetConvar('playerNames_template', '[{{id}}] {{name}}')
-    
+
     if curTemplate ~= template then
         setNameTemplate(-1, template)
 
@@ -20,7 +20,7 @@ local function detectUpdates()
         local newTag = formatPlayerNameTag(v, template)
         if newTag ~= curTags[v] then
             setName(v, newTag)
-            
+
             curTags[v] = newTag
         end
     end
@@ -37,8 +37,7 @@ AddEventHandler('playerDropped', function()
     activePlayers[source] = nil
 end)
 
-RegisterNetEvent('playernames:init')
-AddEventHandler('playernames:init', function()
+RegisterNetEvent('playernames:init', function()
     reconfigure(source)
     activePlayers[source] = true
 end)