Code modernize (#234)

* refactor: declare exports at runtime and drop the player-data provides alias

Signed-off-by: Mathu-lmn <[email protected]>

* refactor: pass handlers directly to RegisterNetEvent

Signed-off-by: Mathu-lmn <[email protected]>

* refactor: use CreateThread/Wait without the Citizen prefix

Signed-off-by: Mathu-lmn <[email protected]>

* chore: remove trailing whitespace, stray lines and unused locals

Signed-off-by: Mathu-lmn <[email protected]>

---------

Signed-off-by: Mathu-lmn <[email protected]>

resources/[gameplay]/[examples]/money/client.lua

@@ -3,9 +3,7 @@ local moneyTypes = {
     bank = `BANK_BALANCE`,
 }
 
-RegisterNetEvent('money:displayUpdate')
-
-AddEventHandler('money:displayUpdate', function(type, money)
+RegisterNetEvent('money:displayUpdate', function(type, money)
     local stat = moneyTypes[type]
     if not stat then return end
     StatSetInt(stat, math.floor(money))

resources/[gameplay]/[examples]/money/fxmanifest.lua

@@ -12,5 +12,6 @@ game 'gta5'
 client_script 'client.lua'
 server_script 'server.lua'
 
---dependency 'cfx.re/playerData.v1alpha1'
 lua54 'yes'
+
+dependency 'player-data'

resources/[gameplay]/[examples]/money/server.lua

@@ -1,4 +1,4 @@
-local playerData = exports['cfx.re/playerData.v1alpha1']
+local playerData = exports['player-data']
 
 local validMoneyTypes = {
     bank = true,
@@ -88,9 +88,7 @@ AddEventHandler('money:updated', function(data)
     end
 end)
 
-RegisterNetEvent('money:requestDisplay')
-
-AddEventHandler('money:requestDisplay', function()
+RegisterNetEvent('money:requestDisplay', function()
     local source = source
     local playerId = playerData:getPlayerId(source)